[gpars-dev] Codehaus Bamboo

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[gpars-dev] Codehaus Bamboo

Russel Winder-2
Do we bother about the Codehaus Bamboo test fail in the light of
TeamCity, Travis_CI, and Snap-CI all being green?

--
Russel.
=============================================================================
Dr Russel Winder      t: +44 20 7585 2200   voip: sip:[hidden email]
41 Buckmaster Road    m: +44 7770 465 077   xmpp: [hidden email]
London SW11 1EN, UK   w: www.russel.org.uk  skype: russel_winder

signature.asc (188 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [gpars-dev] Codehaus Bamboo

Vaclav
Administrator
It appears to be a networking timeout issue to me. If that is the case, I'd suggest moving this one to integration tests. Rafal, what is your opinion?

Vaclav


On Sat, Feb 21, 2015 at 8:35 PM, Russel Winder <[hidden email]> wrote:
Do we bother about the Codehaus Bamboo test fail in the light of
TeamCity, Travis_CI, and Snap-CI all being green?

--
Russel.
=============================================================================
Dr Russel Winder      t: <a href="tel:%2B44%2020%207585%202200" value="+442075852200">+44 20 7585 2200   voip: [hidden email]
41 Buckmaster Road    m: <a href="tel:%2B44%207770%20465%20077" value="+447770465077">+44 7770 465 077   xmpp: [hidden email]
London SW11 1EN, UK   w: www.russel.org.uk  skype: russel_winder



--
Reply | Threaded
Open this post in threaded view
|

Re: [gpars-dev] Codehaus Bamboo

Rafał Sławik
If were talking here about DiscoveryServiceTest, I moved it to integration.

2015-02-22 12:33 GMT+01:00 Václav Pech <[hidden email]>:
It appears to be a networking timeout issue to me. If that is the case, I'd suggest moving this one to integration tests. Rafal, what is your opinion?

Vaclav


On Sat, Feb 21, 2015 at 8:35 PM, Russel Winder <[hidden email]> wrote:
Do we bother about the Codehaus Bamboo test fail in the light of
TeamCity, Travis_CI, and Snap-CI all being green?

--
Russel.
=============================================================================
Dr Russel Winder      t: <a href="tel:%2B44%2020%207585%202200" value="+442075852200" target="_blank">+44 20 7585 2200   voip: [hidden email]
41 Buckmaster Road    m: <a href="tel:%2B44%207770%20465%20077" value="+447770465077" target="_blank">+44 7770 465 077   xmpp: [hidden email]
London SW11 1EN, UK   w: www.russel.org.uk  skype: russel_winder



--



--
Rafał Sławik
Reply | Threaded
Open this post in threaded view
|

Re: [gpars-dev] Codehaus Bamboo

Russel Winder-2
In reply to this post by Vaclav
On Sun, 2015-02-22 at 12:33 +0100, Václav Pech wrote:
> It appears to be a networking timeout issue to me. If that is the case, I'd
> suggest moving this one to integration tests. Rafal, what is your opinion?

Works for me given it seems like an integration rather than unit test.
On the other hand we need to CI the integration tests as well as the
unit tests. At this point I have no idea how to do that on the public CI
servers as they all seem determined to fail our integration tests.

--
Russel.
=============================================================================
Dr Russel Winder      t: +44 20 7585 2200   voip: sip:[hidden email]
41 Buckmaster Road    m: +44 7770 465 077   xmpp: [hidden email]
London SW11 1EN, UK   w: www.russel.org.uk  skype: russel_winder

signature.asc (188 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [gpars-dev] Codehaus Bamboo

Russel Winder-2
In reply to this post by Rafał Sławik
On Sun, 2015-02-22 at 13:18 +0100, Rafał Sławik wrote:
> If were talking here about DiscoveryServiceTest, I moved it to integration.
> https://github.com/rslawik/GPars/tree/remoting-jdk7
>

Make a pull request?

Or I guess we can cheat and just merge and push the change?

--
Russel.
=============================================================================
Dr Russel Winder      t: +44 20 7585 2200   voip: sip:[hidden email]
41 Buckmaster Road    m: +44 7770 465 077   xmpp: [hidden email]
London SW11 1EN, UK   w: www.russel.org.uk  skype: russel_winder

signature.asc (188 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [gpars-dev] Codehaus Bamboo

Rafał Sławik
In my opinion it is a minor change. We could just "add" it as a part of previous merge.

2015-02-22 14:32 GMT+01:00 Russel Winder <[hidden email]>:
On Sun, 2015-02-22 at 13:18 +0100, Rafał Sławik wrote:
> If were talking here about DiscoveryServiceTest, I moved it to integration.
> https://github.com/rslawik/GPars/tree/remoting-jdk7
>

Make a pull request?

Or I guess we can cheat and just merge and push the change?

--
Russel.
=============================================================================
Dr Russel Winder      t: +44 20 7585 2200   voip: [hidden email]
41 Buckmaster Road    m: +44 7770 465 077   xmpp: [hidden email]
London SW11 1EN, UK   w: www.russel.org.uk  skype: russel_winder



--
Rafał Sławik
Reply | Threaded
Open this post in threaded view
|

Re: [gpars-dev] Codehaus Bamboo

Russel Winder-2
On Sun, 2015-02-22 at 15:16 +0100, Rafał Sławik wrote:
> In my opinion it is a minor change. We could just "add" it as a part
> of previous merge.

I became (possibly overly) active and merged the commit and pushed to
the mainline. Hopefully everything that was green remains so.

--
Russel.
=============================================================================
Dr Russel Winder      t: +44 20 7585 2200   voip: sip:[hidden email]
41 Buckmaster Road    m: +44 7770 465 077   xmpp: [hidden email]
London SW11 1EN, UK   w: www.russel.org.uk  skype: russel_winder

signature.asc (188 bytes) Download Attachment